Topic: Error Log Issues

[Stryder87]

Hi All

I'm looking at the error log my web site is generating (it's a massive 8.5Mb for only a month worth of log entries), and I was hoping someone could help out with some of the errors (www.moodyweather.ca).

The following three are generated, on average, approximately every 30 seconds (can range from every 15-40 seconds):

PHP Notice:  Undefined property: stdClass::$windspdmph_avg10m in .../public_html/AWNtags.php on line 1108
- line is:     $WX['wind10Avg'] = AWN_convertWind((string)$json->windspdmph_avg10m,'mph',$uomWind); /* 10 Minute Average Wind Speed*  */

PHP Notice:  Undefined property: stdClass::$yearlyrainin in .../public_html/AWNtags.php on line 1144
- line is:    $WX['totalRain'] = AWN_convertRain((string)$json->yearlyrainin,'in',$uomRain); /* Yearly Rain   */

PHP Warning:  A non-numeric value encountered in .../public_html/AWNtags.php on line 444
- line is:    $return   = round($out*$amount,1);


The following four lines only show up about 4 times in the entire month:

PHP Warning:  reset() expects parameter 1 to be array, null given in .../public_html/get-metar-conditions-inc.php on line 651
- line is:   reset($Conditions); // Do search in load order

PHP Warning:  Invalid argument supplied for foreach() in .../public_html/get-metar-conditions-inc.php on line 656
- line is:   foreach($Conditions as $cond => $condrec) { // look for matching condition

PHP Notice:  Undefined variable: metarGMT in .../public_html/get-metar-conditions-inc.php on line 172
- line is:   $metarGMT

PHP Notice:  Undefined index: RAW-METAR in .../public_html/include-metar-display.php on line 243
- line is:   print "     <td class=\"data1\" colspan=\"2\"><small>".$mtr['RAW-METAR']."</small></td>\n";

Now, my web site is in metric, so I can understand the first 2 being a problem about Imperial measurements, and I guess I'm more looking on how to stop these errors from being generated since they constitute, by far, the biggest part of the entire error log.  Would simply commenting out the lines be sufficient or could that cause problems elsewhere?  As for the 3rd line, I'm at a loss on how it could be complaining about a 'non-numeric' value.

As for the last 4 lines, since they are generated so rarely I'm not as concerned about them, but it would still be nice to get them resolved.  Honestly, I have no idea what they are referring to.  The only thing I see on the Almanac/Nearby METAR Reports that could be an issue is the one status for the White Rock station doesn't update like the rest do.

Thanks.

[saratogaWX]

Well, this is a fun one...  For these three errata

PHP Notice:  Undefined property: stdClass::$windspdmph_avg10m in .../public_html/AWNtags.php on line 1108
- line is:     $WX['wind10Avg'] = AWN_convertWind((string)$json->windspdmph_avg10m,'mph',$uomWind); /* 10 Minute Average Wind Speed*  */

PHP Notice:  Undefined property: stdClass::$yearlyrainin in .../public_html/AWNtags.php on line 1144
- line is:    $WX['totalRain'] = AWN_convertRain((string)$json->yearlyrainin,'in',$uomRain); /* Yearly Rain   */

PHP Warning:  A non-numeric value encountered in .../public_html/AWNtags.php on line 444
- line is:    $return   = round($out*$amount,1);

the root cause is that the JSON returned for your device from ambientweather API differs from the 'standard' response as documented by the the API docs here and here

Specifically, the differences are your station reports these in the JSON:

   "eventrainin": 0,
   "weeklyrainin": 0,
   "totalrainin": 2.11,

when what is expected is

   "yearlyrainin": 13.4,

also my station (Davis VP) provides
   "windgustdir": 37,
   "winddir_avg2m": 23,
   "windspdmph_avg2m": 4,
   "winddir_avg10m": 343,
   "windspdmph_avg10m": 3.8,

that are not provided by your station.

The fix for the yearlyrainin v.s. totalrainin is an easy one.  The line 444 errata is due to this issue too.
The missing windspdmph_avg10m is a bit more complicated -- I'll have to find a provided variable to use.

For the 4 get-metar-conditions-inc.php errata, it it likely that a request for the METAR to tgftp.nws.noaa.gov server failed, and a blank metar was attempted to be parsed.  Not normally an issue.

I'll try to work up a fix for the other issues shortly.

[Stryder87]

Thanks Ken.  I appreciate all your help!

[saratogaWX]

Sorry for the delay.. had granddaughters (4yr and 6yr) overnight.

Try the attached V1.05 of AWNtags.php on your site.. should fix the AWNtags.php Notice: errata (and display your total rain now too).

[Stryder87]

Thanks for the file Ken.  I transferred it to my site at 11:34am.  I just downloaded the log again now, almost an hour and a half later, and there isn't a single new entry in it since 11:34am.  It looks like it's working perfectly!

Thanks for all the time and work you put into that fix.  I really appreciate it!  If I delete the log file, will it recreate a new one if any other errors show up, or would it cause a problem?

Now, if I can only figure out the cron job save yesterday issue!

[saratogaWX]

Yes, the error_log file will be recreated after you delete is (by the first error reported).

The cron-yday.txt cron job is identical to what I'm using on 1and1 (except for the specific site changes needed).

The

Code: [Select]

  $PHPcmd -q $SCRIPT >> $LOGFILE  2> /dev/null
does create a ./cache/saveYesterday.php.txt file on my site (and continues to update it daily).
I don't know why it doesn't work the same on your GoDaddy site .. the script is, however, running successfully on your site -- it's just the link on the wxstatus.php page for the log file that gets a 404-Not Found.   

[Stryder87]

It's very odd as the job runs, but simply will not create the log file.  Ah well.

On the original topic, I just got a new entry in the error log for the get-metar-conditions-inc.php file (lines 172, 651 and 656).  I did a thorough search through the log file (thanks to Notepad++) and found my initial impressions on the frequency of those errors was quite incorrect.  They seem to get thrown 8-9 times a day, not every 3-4 days.  Since you said it could be something on NOAAs end and not a big issue, it's not a big concern.  I'm curious though, I thought NOAA was only for the US and didn't cover areas of Canada?  If that's so, then what on my web site would be poling NOAA?  I thought everything was coming from Environment Canada.

[saratogaWX]

The tgftp.nws.noaa.gov server actually collects metar reports worldwide, so the Canada reports are there too.

With the AWN-plugin (and others), a call is made to get-metar-conditions-inc.php to retrieve the sky conditions from the metar specified in Settings-weather.php $SITE['conditionsMETAR'] entry. -- you're using CWMM for your sky conditions.

CWWN is currently showing (on your wxmetar.php page)

CWMM - P. Meadows Cs Au, British Columbia, Canada
Distance from station: E 17km
Updated: Thu, 08-02-2018 5:00pm PDT

   Wind from S
Wind: S 7 km/h
Temperature:    21°C
Dew Point:    11°C
Humidity:    53%
2018/08/03 00:00 CWMM 030000Z AUTO 19004KT 21/11 RMK AO1 SLP171 T02070112 56008

And doesn't have sky conditions.  I'd suggest changing to CYVR which shows

CYVR - Vancouver Intl A, British Columbia, Canada
Distance from station: WSW 19km
Updated: Thu, 08-02-2018 5:00pm PDT
Mostly cloudy
Mostly cloudy    Wind from SE
Wind: SE 19 km/h
Temperature:    21°C
Dew Point:    13°C
Humidity:    60%
Barometer:    1016.9 hPa
Clouds:    Mostly cloudy
Visibility:    48 km
Cloud details:    Few Clouds 1128 m
Few Clouds 1372 m
Partly cloudy 6706 m
Mostly cloudy 7620 m
2018/08/03 00:00 CYVR 030000Z 14010KT 30SM FEW037 FEW045 SCT220 BKN250 21/13 A3003 RMK CU1SC1CI2CS1 SLP169 DENSITY ALT 600FT

and would display a more accurate picture of clouds (Mostly Cloudy) instead of the default Partly Cloudy due to the missing cloud info in CWMM

[Stryder87]

Since I have 5 locations listed, is it only looking at the first one for the information?  If so, would just changing the order be good enough (putting CYVR first in the list)?

I'm assuming that this is the list used to generate the Almanac/Nearby METAR Reports page, correct?

[saratogaWX]

There are two different entries for a metar.
The one in Settings-weather.php for $SITE['conditionsMETAR'] is the ONLY one used to determine your icon.. there's no fallback/failover if that one doesn't have sky conditions.

The ones in the wxmetar.php page $MetarList array are ALL polled for display, but none of them are directly used for the conditions display on your homepage -- only for the icons on the wxmetar.php page.

[Stryder87]

Ah... ok, I see.  I totally forgot about that setting.  I changed it now and immediately noticed the icon changed.  I'm also noticing that, since putting in the updated file you sent me, my page is loading significantly faster than before.  It actually feels like a real web page now!  haha   

There are two lines in the error log I haven't seen before (or, at least, are really rare).  Any idea what these are?  It's about the last unknown ones there are now:

PHP Notice:  Undefined variable: newestImageIdx in .../public_html/ec-lightning.php on line 894
Line= <img src="<?php echo $lightningDir . "lightning-$lightningID-${newestImageIdx}.png"; ?>" alt="<?php echo $siteTitle; ?>" width="<?php echo $new_width; ?>" height="<?php echo $new_height; ?>" id="<?php echo $lightningID; ?>L_Ath_Slide" title="<?php echo $siteTitle; ?>" /></p>

PHP Warning:  session_start(): Cannot start session when headers already sent in .../public_html/include-style-switcher.php on line 31
Line=     session_start();

[saratogaWX]

Oooh, another subtle one.

Replace in ec-lightning.php

Code: [Select]

function ECL_gen_animation ( $numImages, $lightningID, $lightningDir, $aniSec) {
// generate JavaScript and control buttons for rotating the images
  global $new_width, $new_height, $siteTitle, $imgListText, $ECLPlay, $ECLPrev, $ECLNext, $ECLNoJS,
    $siteHeading, $noJSMsg, $ECLNO, $TZ, $TZOffsecSecs, $autoPlay, $ECLlegend, $siteDescription;
with

Code: [Select]

function ECL_gen_animation ( $numImages, $lightningID, $lightningDir, $aniSec) {
// generate JavaScript and control buttons for rotating the images
  global $new_width, $new_height, $siteTitle, $imgListText, $ECLPlay, $ECLPrev, $ECLNext, $ECLNoJS,
    $siteHeading, $noJSMsg, $ECLNO, $TZ, $TZOffsecSecs, $autoPlay, $ECLlegend, $siteDescription,$newestImageIdx;
That will fix the Notice: error, and the Notice: errata was causing the session_start() error

[Stryder87]

Ok, fixed that up.  The page is definitely loading faster now.

Looks like our old friend AWNtags is decided to pop up again.

PHP Notice:  Undefined index: wind10Avg in .../public_html/AWNtags.php on line 1660
Line= $JSONdata["Tbeaufort"]  = 'F'.AWN_getBeaufort(AWN_convertWind($WX['wind10Avg'],$uomWind,'kts')); // WD Sample= '3'


And oddly enough, those three errors from get-metar-conditions-inc.php are showing up again.  Exactly the same.

[saratogaWX]

Change that line

Code: [Select]

$JSONdata["Tbeaufort"]  = 'F'.AWN_getBeaufort(AWN_convertWind($WX['wind10Avg'],$uomWind,'kts')); // WD Sample= '3' to

Code: [Select]

$JSONdata["Tbeaufort"]  = 'F'.AWN_getBeaufort(AWN_convertWind($WX['windSpeed'],$uomWind,'kts')); // WD Sample= '3'Guess I forgot that one reference to wind10Avg not produced by your system.

Try changing get-metar-conditions-inc.php from

Code: [Select]

function mtr_load_iconDefs()
{
  global $Icons, $IconsLarge, $IconsText, $Conditions, $Debug;
to

Code: [Select]

function mtr_load_iconDefs()
{
  global $Icons, $IconsLarge, $IconsText, $Conditions, $Debug;
  $Conditions = array();


[Stryder87]

Ok, I made the changes.  The error log is still getting the three get-metar-conditions-inc.php errors, anywhere from 3-12 minutes apart.  Was the change to the get-metar-conditions-inc.php file supposed to be on a separate line or just a continuation of the existing line?  I made it a new line considering that $Debug had a semi-colon after it.

Regarding the metarGMT being referred to as an undefined variable, is it possible that I didn't set that somewhere in one of the other files and it's trying to call that variable and it's blank?

[zmarfak]

Hi,
now that my error log is a lot (really a lot) cleared up by avoiding errors indicated in topic https://www.wxforum.net/index.php?topic=34791.0
I have the following errors that seems to come up regularly :
 in get-metar-conditions-inc.php

Code: [Select]

PHP Warning:  reset() expects parameter 1 to be array, null given in /var/www/vhosts/matar.be/httpdocs/weather/get-metar-conditions-inc.php on line 651
PHP Warning:  Invalid argument supplied for foreach() in /var/www/vhosts/matar.be/httpdocs/weather/get-metar-conditions-inc.php on line 656
in  WU-History.php  :

Code: [Select]

PHP Warning:  sizeof(): Parameter must be an array or an object that implements Countable in /var/www/vhosts/matar.be/httpdocs/weather/WU-History.php on line 283
PHP Warning:  Invalid argument supplied for foreach() in /var/www/vhosts/matar.be/httpdocs/weather/WU-History.php on line 284
PHP Warning:  sizeof(): Parameter must be an array or an object that implements Countable in /var/www/vhosts/matar.be/httpdocs/weather/WU-History.php on line 292
PHP Warning:  sizeof(): Parameter must be an array or an object that implements Countable in /var/www/vhosts/matar.be/httpdocs/weather/WU-History.php on line 310
less often in  WU-History.php :

Code: [Select]

PHP Warning:  array_shift() expects parameter 1 to be array, null given in /var/www/vhosts/matar.be/httpdocs/weather/WU-History.php on line 295
PHP Warning:  Division by zero in /var/www/vhosts/matar.be/httpdocs/weather/WU-History.php on line 1265
Is there any indication if this can be avoided or is this inherent on the data (not) provided by metar and WU ?
Thanks for any input.

[Stryder87]

So having let it run for the long weekend, there are some new errors showing up in the 'ec-forcast.php' file along with the three 'get-metar-conditions-inc.php' ones.  Interestingly enough, they all happened at the same time, [06-Aug-2018 05:50:43 America/Vancouver], and only once over the long weekend.  Maybe it was something on GoDaddy or Environment Canada's end.  But, I'll list them here just in case.  I'd still like the 'get-metar-conditions...' errors figured out.  They still happen frequently.

PHP Notice:  Undefined offset: 0 in .../public_html/ec-forecast.php on line 1496  -(the line repeats with the 0 counting all the way up to 23)
Line =       $F = $forecasthours[$i];

PHP Notice:  Trying to get property 'temperature' of non-object in .../public_html/ec-forecast.php on line 1048
Line =    $UOMTempUsed = "&deg;".(string)$xml->hourlyForecastGroup->hourlyForecast[0]->temperature['units'];

PHP Notice:  Trying to get property 'wind' of non-object in .../public_html/ec-forecast.php on line 1049
Line =    $UOMWindUsed = (string)$xml->hourlyForecastGroup->hourlyForecast[0]->wind->speed['units'];

PHP Notice:  Trying to get property 'speed' of non-object in .../public_html/ec-forecast.php on line 1049
Line =    $UOMWindUsed = (string)$xml->hourlyForecastGroup->hourlyForecast[0]->wind->speed['units'];

PHP Notice:  Undefined variable: forecasttext in .../public_html/ec-forecast.php on line 1221
Line =   for ($i=0;$i<count($forecasttext);$i++) {

PHP Warning:  count(): Parameter must be an array or an object that implements Countable in .../public_html/ec-forecast.php on line 1221
Line =   for ($i=0;$i<count($forecasttext);$i++) {

PHP Warning:  Division by zero in .../public_html/ec-forecast.php on line 1591
Line = $wdth = intval(100/(count($forecasticon)/2));

PHP Notice:  Undefined offset: 0 in .../public_html/ec-forecast.php on line 1636
Line = if($forecasttemptype[0] == 'min') { $iStart = -1; } else { $iStart = 0; }

PHP Notice:  Undefined variable: forecastdays in .../public_html/ec-forecast.php on line 1740
Line = for ($g=0;$g < count($forecastdays);$g++) {

PHP Warning:  count(): Parameter must be an array or an object that implements Countable in .../public_html/ec-forecast.php on line 1740
Line = for ($g=0;$g < count($forecastdays);$g++) {

[saratogaWX]

The ec-forecast.php Notice errata seem to point to incomplete XML returned from the EC website.  Hard to tell just based on the error messages.

You might consider just turning off the Notice errata in the error log -- they are not harmful errors and can be safely ignored on a production site.

Use a php.ini entry of

Code: [Select]

error_reporting = E_ALL & ~E_NOTICE to have PHP report only the genuinely meaningful errata to you.

[Stryder87]

So I made all the changes mentioned and let it go a couple days.  Looks like I'm just down to the two following errors being generated (multiple times an hour):

[10-Aug-2018 15:04:23 America/Vancouver] PHP Warning:  reset() expects parameter 1 to be array, null given in /home/.../public_html/get-metar-conditions-inc.php on line 652
Line =  reset($Conditions); // Do search in load order

[10-Aug-2018 15:04:23 America/Vancouver] PHP Warning:  Invalid argument supplied for foreach() in /home/.../public_html/get-metar-conditions-inc.php on line 657
Line =   foreach($Conditions as $cond => $condrec) { // look for matching condition


Not bad.   

[saratogaWX]

Ok, try the attached get-metar-conditions-inc.php V1.18  .. I tried it on my GoDaddy testing site (saratogawx.net PHP Version: 7.2.6) with no errata.

[ConligWX]

Ok, try the attached get-metar-conditions-inc.php V1.18  .. I tried it on my GoDaddy testing site (saratogawx.net PHP Version: 7.2.6) with no errata.

looks good here too. no errors reported.

[Stryder87]

Ok, try the attached get-metar-conditions-inc.php V1.18  .. I tried it on my GoDaddy testing site (saratogawx.net PHP Version: 7.2.6) with no errata.

Alright.  I'll fire that in there and let it run for a while and see if anything shows up in the log.
Thanks.

[BCJKiwi]

Is this actually v117 as shown in the file or v118?

This fixed all the same errors discussed here that were showing up a php v7.2.7 error log
Also OK with PHP v 7.2.8

Also the page loads faster now!

[saratogaWX]

Sigh, Guess I'm getting a bit unmindful in my dotage ..  It's really V1.17 despite what the above attached .zip and comments say about V1.18

Thanks for letting me know that it fixed your Notice errata too.  I'm waiting to hear from Stryder87 about his error_log before I release it generally

[BCJKiwi]

All good.

I really don't know how you manage to keep everything updated and in sync - a truly wonderous achievement and a huge service to all the users of your scripts.

A heartfelt THANK YOU.